Update kaleido and plotly versions#163
Conversation
|
Why wasn't this catched by C.I.?? |
|
Seems to only prompt when trying to save to a local file. Adding a simple test now for avoiding future problems |
| from pyodi.plots.common import plot_scatter_with_histograms | ||
|
|
||
|
|
||
| @logger.catch |
There was a problem hiding this comment.
@daavoo this was catching all exceptions without reraising anything... so if something crashes, tests simply skips it. Can't recall why did we add this
There was a problem hiding this comment.
It should be: logger.catch(reraise=True)
There was a problem hiding this comment.
I think we should remove all those decorator.
This is useful to ensure unexpected exceptions are logged, the entire program can be wrapped by this method
https://loguru.readthedocs.io/en/stable/api/logger.html#loguru._logger.Logger.catch
I am not seeing any advantage on using this here
There was a problem hiding this comment.
As you wish. With reraise=True the exceptions would work as without the decorator. In the past, I had found the additional information showed by loguru useful for debugging exceptions.
There was a problem hiding this comment.
I think I'll remove all those decorators in a different issue, let's merge this for now
2 participants
Fixes kaleido permission err:
PermissionError: [Errno 13] Permission denied: '/home/mmendez/anaconda3/envs/pyodi/lib/python3.7/site-packages/kaleido-0.1.0-py3.7-linux-x86_64.egg/kaleido/executable/kaleido'