Feature: make JSON indentation configurable when merging COCO files#171
Merged
mmeendez8 merged 7 commits intoDec 14, 2021
Merged
Conversation
daavoo
suggested changes
Dec 13, 2021
Collaborator
daavoo
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I would suggest adding a simple check (in https://github.com/Gradiant/pyodi/blob/master/tests/apps/test_coco_merge.py) ensuring that indent is passed to json.dump.
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Contributor
Author
|
@daavoo thank you for your feedback. I applied all of your suggestions. As requested, I have added a unit test where I patch the call to |
daavoo
approved these changes
Dec 13, 2021
mmeendez8
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for providing this great library. I had the issue that merging two COCO files (each 2.8 MB in size) resulted in a 19 MB large COCO JSON file (too large in my opinion). The huge difference in size was caused by the JSON indentation which is set to 2 spaces:
pyodi/pyodi/apps/coco/coco_merge.py
Lines 90 to 91 in d48b39c
Previously:
Merging two COCO files with fixed indentation of 2 spaces:
resulted in:
With my changes:
Merging the same two COCO files with indentation disabled by setting
json_indentation=None:results in: