Skip to content

Add option to use EXIF orientation from image metadata#185

Merged
jorgenusan merged 3 commits into
Gradiant:masterfrom
Code-and-Caviar:master
Jan 23, 2023
Merged

Add option to use EXIF orientation from image metadata#185
jorgenusan merged 3 commits into
Gradiant:masterfrom
Code-and-Caviar:master

Conversation

@tracek
Copy link
Copy Markdown
Contributor

@tracek tracek commented Jan 23, 2023

When loading an image for painting annotations, Pillow is used to load the image. Trouble is, the Image.open function does not take EXIF information into the consideration, so the width and height might end up swapped in the result.

The PR adds an option to use EXIF orientation information to transpose the image if necessary.

jorgenusan
jorgenusan previously approved these changes Jan 23, 2023
Copy link
Copy Markdown
Contributor

@jorgenusan jorgenusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

daniperfer
daniperfer previously approved these changes Jan 23, 2023
@daniperfer daniperfer self-requested a review January 23, 2023 09:35
@jorgenusan jorgenusan dismissed their stale review January 23, 2023 09:40

pre-commit lint error

@jorgenusan
Copy link
Copy Markdown
Contributor

We have moved ahead of the lint workflow. Can you please correct this?
In our contribution guide it says how, the pre-commit itself should update the file to match the style of code we use.

Thank you very much!

@jorgenusan jorgenusan dismissed daniperfer’s stale review January 23, 2023 09:42

pre-commit lint error

@tracek
Copy link
Copy Markdown
Contributor Author

tracek commented Jan 23, 2023

Fixed now, thanks! And sorry, I haven't noticed the guidelines before.

@jorgenusan jorgenusan merged commit 4007084 into Gradiant:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants