Skip to content

Convert functional test kits to Kotlin and NIO #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Goooler merged 28 commits into from
Dec 25, 2024
Merged

Convert functional test kits to Kotlin and NIO #1087

Goooler merged 28 commits into from
Dec 25, 2024

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Dec 4, 2024 •
edited
Loading

@Goooler Goooler force-pushed the g/20241204/convert-test-kits branch 4 times, most recently from f70615b to b9a8c2d Compare December 9, 2024 10:48
@Goooler Goooler mentioned this pull request Dec 9, 2024
Merged
@Goooler Goooler force-pushed the g/20241204/convert-test-kits branch 3 times, most recently from 5550deb to af07f46 Compare December 10, 2024 08:28
@Goooler Goooler mentioned this pull request Dec 11, 2024
Merged
@Goooler Goooler force-pushed the g/20241204/convert-test-kits branch 9 times, most recently from 0755162 to 18c00e6 Compare December 17, 2024 03:34
Goooler
Goooler commented Dec 17, 2024
View reviewed changes
@Goooler Goooler requested a review from Copilot December 17, 2024 04:11
Copilot AI reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 24 changed files in this pull request and generated no comments.

Files not reviewed (19)
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ApplicationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/BasePluginSpecification.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigurationCacheSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/FilteringSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/PublishingSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/RelocationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/caching/AbstractCachingSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/AbstractMavenModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileRepository.groovy: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableJar.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/repo/AbstractModule.kt: Language not supported

@Goooler Goooler marked this pull request as ready for review December 17, 2024 04:11
@Goooler Goooler force-pushed the g/20241204/convert-test-kits branch 4 times, most recently from 8c9c44e to e6fd715 Compare December 22, 2024 15:29
@Goooler Goooler force-pushed the g/20241204/convert-test-kits branch from e6fd715 to 970bd5d Compare December 24, 2024 01:15
@Goooler Goooler requested a review from Copilot December 24, 2024 01:26
Copilot AI reviewed Dec 24, 2024
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (19)
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ApplicationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/BasePluginSpecification.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigurationCacheSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/FilteringSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/PublishingSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/RelocationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/caching/AbstractCachingSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/AbstractMavenModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileRepository.groovy: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableJar.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/HashUtil.kt: Language not supported

@Goooler Goooler requested a review from Copilot December 25, 2024 04:58
Copilot AI reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 30 changed files in this pull request and generated no comments.

Files not reviewed (19)
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ApplicationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/BasePluginSpecification.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigurationCacheSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/FilteringSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/PublishingSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/RelocationSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/caching/AbstractCachingSpec.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileRepository.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/FileExtensions.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/AbstractMavenModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileModule.groovy: Language not supported
  • src/funcTest/groovy/com/github/jengelman/gradle/plugins/shadow/util/repo/maven/MavenFileRepository.groovy: Language not supported
  • src/funcTest/resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableJar.kt: Language not supported
  • src/intiTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/AppendableMavenFileModule.kt: Language not supported

@Goooler Goooler changed the title Convert functional test kits to Kotlin Convert functional test kits to Kotlin and Path Dec 25, 2024
@Goooler Goooler changed the title Convert functional test kits to Kotlin and Path Convert functional test kits to Kotlin and NIO Dec 25, 2024
@Goooler Goooler merged commit a2c30ec into main Dec 25, 2024
7 checks passed
@Goooler Goooler deleted the g/20241204/convert-test-kits branch December 25, 2024 06:04
@Goooler Goooler mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Goooler