Skip to content

Share test kits in a new source set#1747

Merged
Goooler merged 8 commits intomainfrom
g/20250915/share-test-kits
Sep 15, 2025
Merged

Share test kits in a new source set#1747
Goooler merged 8 commits intomainfrom
g/20250915/share-test-kits

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Sep 15, 2025

Addresses #1081.

@Goooler Goooler requested a review from Copilot September 15, 2025 07:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes test utilities by creating a new testKit source set that contains shared test utility code. The main purpose is to consolidate common test functionality that was previously spread across different packages, making it more reusable and better organized.

  • Moves utilities from com.github.jengelman.gradle.plugins.shadow.util and com.github.jengelman.gradle.plugins.shadow.internal to a new testkit package
  • Creates dedicated test kit classes for JAR manipulation, resource loading, and test utilities
  • Updates all test files to import utilities from the new testkit package instead of the old locations

Reviewed Changes

Copilot reviewed 33 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/testKit/kotlin/com/github/jengelman/gradle/plugins/shadow/testkit/Resource.kt New utility functions for loading test resources as streams and paths
src/testKit/kotlin/com/github/jengelman/gradle/plugins/shadow/testkit/JarPath.kt Moved JAR manipulation utilities from util package with package rename
src/testKit/kotlin/com/github/jengelman/gradle/plugins/shadow/testkit/Utils.kt Moved test utilities from util package with package rename
Multiple test files Updated imports to use new testkit package instead of old util and internal packages
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt Removed resource loading functions that were moved to testkit

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Goooler Goooler enabled auto-merge (squash) September 15, 2025 08:09
@Goooler Goooler merged commit 6e758df into main Sep 15, 2025
8 checks passed
@Goooler Goooler deleted the g/20250915/share-test-kits branch September 15, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant