Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes test utilities by creating a new testKit source set that contains shared test utility code. The main purpose is to consolidate common test functionality that was previously spread across different packages, making it more reusable and better organized.
- Moves utilities from
com.github.jengelman.gradle.plugins.shadow.utilandcom.github.jengelman.gradle.plugins.shadow.internalto a newtestkitpackage - Creates dedicated test kit classes for JAR manipulation, resource loading, and test utilities
- Updates all test files to import utilities from the new
testkitpackage instead of the old locations
Reviewed Changes
Copilot reviewed 33 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/testKit/kotlin/com/github/jengelman/gradle/plugins/shadow/testkit/Resource.kt | New utility functions for loading test resources as streams and paths |
| src/testKit/kotlin/com/github/jengelman/gradle/plugins/shadow/testkit/JarPath.kt | Moved JAR manipulation utilities from util package with package rename |
| src/testKit/kotlin/com/github/jengelman/gradle/plugins/shadow/testkit/Utils.kt | Moved test utilities from util package with package rename |
| Multiple test files | Updated imports to use new testkit package instead of old util and internal packages |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt | Removed resource loading functions that were moved to testkit |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1081.