Configurable source path patterns for Apache license/notice resource transformers #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ApacheLicenseResourceTransformer` effectively removes all `META-INF/LICENSE*` files from the resulting jar. This change _changes_ the behavior of `ApacheLicenseResourceTransformer` to concatenate the included license files. Identical license texts are included once. Adapted the `ApacheLicenseResourceTransformerTest` for this change. Fixes GradleUp#1842
…transformers The current patterns (`META-INF/LICENSE` + `META-INF/NOTICE` et al) work for many dependencies, but sadly not all. Some dependencies put those files in the jar's "root directory". This change allows configuring the set of matched paths, and also allows overriding the output path (just in case).
Contributor
Author
|
(Depends on #1842 / merge-conflicts) |
Goooler
reviewed
Nov 16, 2025
Goooler
reviewed
Nov 16, 2025
Comment on lines
+54
to
+60
| /** | ||
| * Path of the resulting output file. | ||
| * | ||
| * Defaults to `META-INF/NOTICE`. | ||
| */ | ||
| @get:Input | ||
| public open val outputPath: Property<String> = objectFactory.property("META-INF/NOTICE") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current patterns (
META-INF/LICENSE+META-INF/NOTICEet al) work for many dependencies, but sadly not all.Some dependencies put those files in the jar's "root directory".
This change allows configuring the set of matched paths, and also allows overriding the output path (just in case).
Closes #1844.