Add pattern-filterable to PreserveFirstFoundResourceTransformer
#1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Damn - depends on #1854 |
Goooler
reviewed
Nov 17, 2025
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 17, 2025
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Outdated
Show resolved
Hide resolved
1 task
snazy
force-pushed
the
preserve-first-pattern
branch
from
d4b591d to
d8def90
Compare
Goooler
reviewed
Nov 17, 2025
.../github/jengelman/gradle/plugins/shadow/transformers/PatternFilterableResourceTransformer.kt
Outdated
Show resolved
Hide resolved
.../github/jengelman/gradle/plugins/shadow/transformers/PatternFilterableResourceTransformer.kt
Outdated
Show resolved
Hide resolved
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Outdated
Show resolved
Hide resolved
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Outdated
Show resolved
Hide resolved
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 17, 2025
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 17, 2025
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nsformers/PreserveFirstFoundResourceTransformer.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Goooler
approved these changes
Nov 17, 2025
...github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt
Show resolved
Hide resolved
| protected val found: MutableSet<String> = mutableSetOf() | ||
|
|
||
| @get:Deprecated("Use `include(..)` instead") | ||
| @get:Input |
Contributor
Author
There was a problem hiding this comment.
Hm - I'm not sure about removing this. If we remove it, Gradle wouldn't consider it as a cache-key input (and it's not an @Internal either).
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I missed that there is a test for that... The task should be cached due to the includes.
…nsformers/PreserveFirstFoundResourceTransformer.kt
…nsformers/PreserveFirstFoundResourceTransformer.kt
auto-merge was automatically disabled
November 17, 2025 14:16
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1848.