Add FindResourceInClasspath task to find resources in dependencies
#1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
Nov 18, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Outdated
Show resolved
Hide resolved
snazy
force-pushed
the
conv-task-find
branch
2 times, most recently
from
29eb542 to
da91cb0
Compare
Goooler
reviewed
Nov 18, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Show resolved
Hide resolved
Goooler
reviewed
Nov 18, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 18, 2025
...ctionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/FindResourceInClasspathTest.kt
Outdated
Show resolved
Hide resolved
snazy
force-pushed
the
conv-task-find
branch
from
0bd65a1 to
25deca2
Compare
Goooler
reviewed
Nov 18, 2025
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/Paths.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 18, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/FindResourceInClasspath.kt
Show resolved
Hide resolved
Goooler
reviewed
Nov 18, 2025
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/Paths.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 18, 2025
Goooler
reviewed
Nov 18, 2025
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/util/Paths.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Nov 18, 2025
Comment on lines
36
to
38
| "/my/a/1.0/a-1.0.jar".invariantSeparatorsPathString, | ||
| "/a.properties".invariantSeparatorsPathString, | ||
| "/a2.properties".invariantSeparatorsPathString, |
Member
There was a problem hiding this comment.
Seems you need variantSeparatorsPathString instead of invariantSeparatorsPathString.
Goooler
changed the title
FindResourceInClasspath task to find resources in dependencies
…ks/FindResourceInClasspath.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Goooler
reviewed
Nov 18, 2025
| classpath.forEach { file -> | ||
| logger.lifecycle("scanning {}", file) | ||
|
|
||
| archiveOperations.zipTree(file).matching(patternSet).forEach { entry -> |
Member
There was a problem hiding this comment.
I'm not sure if the files will be unzipped for once when the task is executed. If the answer is not, we can mark the task @DisableCachingByDefault.
Contributor
Author
There was a problem hiding this comment.
@DisableCachingByDefault SGTM. It's a debugging convenience tasks anyway, so caching might be counter productive.
I'm not sure whether some zipTree related artifacts end on disk (somewhere in build/tmp) as a byproduct of what the implementation needs. But there's no cacheable output.
Goooler
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka: "which dependencies contain the path XYZ"
Refs #1848.