Introduce CleanProperties #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/groovy/com/github/jengelman/gradle/plugins/shadow/internal/CleanProperties.groovy
Show resolved
Hide resolved
Contributor
Author
|
@johnrengelman can I do anything to move this forward? |
|
@johnrengelman please, can we do anything to move this forward? We are deploying several java applications in one pipeline, and it would be really nice if we could skip the ones that didn't change. And we can't do that now since the hash of the jar always changes... |
|
@johnrengelman will this change be moving forward? |
PropertiesFileTransformer uses `java.utils.Properties` internally as a storage.
`java.utils.Properties` `store0()` contains `bw.write("#" + new Date().toString());` that prepends current timestamp before any content (after comments).
This effectively breaks reproducible builds that use PropertiesFileTransformer because every new build has different timestamp in transformed files.
CleanProperties implementation is introduced in order to remove prepended timestamp when creating output stream.
Contributor
Author
|
Yet another rebase in few years. Fresh master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropertiesFileTransformer uses
java.utils.Propertiesinternally as a storage.java.utils.Propertiesstore0()containsbw.write("#" + new Date().toString());that prepends current timestamp before any content (after comments).This effectively breaks reproducible builds that use PropertiesFileTransformer because every new build has different timestamp in transformed files.
CleanProperties implementation is introduced in order to remove prepended timestamp when creating output stream.