Skip to content

Add exclude gradleApi() by default test #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 2 commits into from
Aug 28, 2024
Merged

Add exclude gradleApi() by default test #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e60974
Update POM_LICENSE_NAME
Goooler Aug 27, 2024
150b5c4
Add `exclude gradleApi() by default` test
Goooler Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ POM_DESCRIPTION=Gradle plugin to create fat/uber JARs, apply file transforms, an
POM_INCEPTION_YEAR=2024
POM_URL=https://github.com/GradleUp/shadow

POM_LICENSE_NAME=The Apache Software License, Version 2.0
POM_LICENSE_NAME=Apache-2.0
POM_LICENSE_URL=https://www.apache.org/licenses/LICENSE-2.0.txt
POM_LICENSE_DIST=repo

Expand All @@ -27,4 +27,4 @@ POM_SCM_DEV_CONNECTION=scm:git:ssh://git@github.com/GradleUp/shadow.git

POM_DEVELOPER_ID=gradleup
POM_DEVELOPER_NAME=GradleUp developers
POM_DEVELOPER_URL=https://github.com/GradleUp
POM_DEVELOPER_URL=https://github.com/GradleUp
35 changes: 35 additions & 0 deletions src/test/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPluginSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,41 @@ class ShadowPluginSpec extends PluginSpecification {
assert result.output.contains('TestApp: Hello World! (foo)')
}

@Issue("https://github.com/GradleUp/shadow/pull/459")
def 'exclude gradleApi() by default'() {
given:
buildFile.text = getDefaultBuildScript('java-gradle-plugin')
buildFile << """
dependencies {
compileOnly gradleApi()
}
""".stripIndent()

file('src/main/java/my/plugin/MyPlugin.java') << """
package my.plugin;
import org.gradle.api.Plugin;
import org.gradle.api.Project;
public class MyPlugin implements Plugin<Project> {
public void apply(Project project) {
System.out.println("MyPlugin: Hello World!");
}
}
""".stripIndent()
file('src/main/resources/META-INF/gradle-plugins/my.plugin.properties') << """
implementation-class=my.plugin.MyPlugin
""".stripIndent()

when:
run('shadowJar')

then:
assert output.exists()

and:
JarFile jar = new JarFile(output)
assert jar.entries().collect().findAll { it.name.endsWith('.class') }.size() == 1
Copy link
Member Author

@Goooler Goooler Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see, Gradle APIs are included in the current jar:

https://scans.gradle.com/s/w4ng474mk6moe/tests/task/:test/details/com.github.jengelman.gradle.plugins.shadow.ShadowPluginSpec/exclude%20gradleApi()%20by%20default?top-execution=1

my/plugin/MyPlugin.class, 
org/gradle/process/internal/worker/GradleWorkerMain.class, 
org/gradle/process/internal/worker/WorkerJvmMemoryInfoSerializer$1.class, 
org/gradle/process/internal/worker/WorkerJvmMemoryInfoSerializer$JvmMemoryStatusSerializer.class, 
org/gradle/process/internal/worker/WorkerJvmMemoryInfoSerializer.class, 
org/gradle/process/internal/worker/WorkerLoggingSerializer.class,
…

}

private String escapedPath(File file) {
file.path.replaceAll('\\\\', '\\\\\\\\')
}
Expand Down