We no longer need suitesparse_graphblas_arm64.h #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
suitesparse_graphblas_arm64.handsuitesparse_graphblas_no_complex.hwas removed in #68 (build.pywas renamed tobuild_graphblas_cffi.pyand the logic for which header to use was changed). We no longer need arm64.h b/c it is now the same as the standard header. I believe this change occurred in #58.Technically, we don't need to generate and keep
suitesparse_graphblas_no_complex.heither since complex works on Windows now, but maybe it's okay/safer to keep around?