Merged
Conversation
Contributor
Author
|
@GrayJack can you review it? |
Owner
|
Can you add |
GrayJack
reviewed
Aug 4, 2020
Tests are incomplete
Contributor
Author
|
|
Added tests for -d, -u and -du
better and consistent error messages other minor adjustments
Contributor
Author
|
PR ready, one more review? So, |
GrayJack
reviewed
Aug 8, 2020
GrayJack
reviewed
Aug 8, 2020
GrayJack
requested changes
Aug 8, 2020
Owner
GrayJack
left a comment
GrayJack
left a comment
There was a problem hiding this comment.
Could you also update the table in the README.md in the status of the uniq? Should be Started since it still didn't implement the -f flag
Owner
|
Sorry for so many reviews, I'm still not used to the VSCode plugin for PR reviews 😆 |
GrayJack
reviewed
Aug 9, 2020
GrayJack
approved these changes
Aug 9, 2020
Owner
|
bors r+ |
Contributor
Closed
Contributor
Author
|
There are several errors with the implementation of the |
marcospb19
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started
Uniq.Progress:
-c|--count-d|--repeated-f|--skip-fields=NImplemented in Uniq: fix -s and implement -f flags #131-s|--skip-chars=N-u|--unique