DateTimePicker Absolute Timerange#9253
Merged
kmerz merged 25 commits intofeature/DateTimePickerfrom Nov 11, 2020
Merged
Conversation
kyleknighted
changed the title
kyleknighted
force-pushed
the
dtp_absolute_timerange
branch
3 times, most recently
from
84079b8 to
bce40ef
Compare
kyleknighted
force-pushed
the
feature/DateTimePicker
branch
from
2956d59 to
3201af6
Compare
kyleknighted
force-pushed
the
dtp_absolute_timerange
branch
from
f1243eb to
52f745e
Compare
kyleknighted
force-pushed
the
feature/DateTimePicker
branch
from
3201af6 to
4ee6d34
Compare
kyleknighted
force-pushed
the
dtp_absolute_timerange
branch
from
ff8f0f3 to
73745cc
Compare
9 tasks
kmerz
requested changes
Nov 6, 2020
kyleknighted
force-pushed
the
dtp_absolute_timerange
branch
from
4f5f8d6 to
491b2e0
Compare
kyleknighted
force-pushed
the
feature/DateTimePicker
branch
from
4ee6d34 to
7d49c4e
Compare
* Migrating original range options to Popover * Converting existing DateTimePicker to Popover * Styling TimeRangeDisplay * Flow Tests * Some Cleanup * temp -> tempTimeRange * Linting * Keyword output * All time ranges loading properly * react hook linting * lint weak objects * Error on TimeRangeDisplay default type
* Migrating original range options to Popover * Converting existing DateTimePicker to Popover * Styling TimeRangeDisplay * Flow Tests * Some Cleanup * Linting * Rendering Live Preview * merge/rebase touchups
* Migrating original range options to Popover * Converting existing DateTimePicker to Popover * Styling TimeRangeDisplay * Flow Tests * Some Cleanup * Linting * merge/rebase touchups * Migrating original range options to Popover * Converting existing DateTimePicker to Popover * Flow Tests * Some Cleanup * Linting * Remove TimerangeSelector * Changing From time updates preview & saveable * Relative From Range working * Layout touchup and handle All Time uncheck * RelativeTimeRangeSelector tests * Clean up configuration of relative times * Disable All Time check if query limit defined * Wroking out a couple responsive issues, but needs more drastic code changes to fix other problems * merge/rebase touchups * lint * Updating some tests to get more passing * lint * reverting & commenting * update to newer function style
kyleknighted
force-pushed
the
dtp_absolute_timerange
branch
from
491b2e0 to
2ea8265
Compare
Contributor
Author
|
@kmerz thank you for the feedback, updated the PR to fix your concerns! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update Absolute TimeRange to allow for more flexibility and control
Future iteration will include ability to toggle between just the top Input and the Calendar/Time Inputs below.
Screenshots (if appropriate):
Types of changes
Checklist: