Cleanup page layout related components.#9909
Merged
Conversation
…archBar` in `AppRouter`.
kmerz
approved these changes
Jan 14, 2021
Member
kmerz
left a comment
kmerz
left a comment
There was a problem hiding this comment.
Look fantastic to me! 🔥
Worked on my machine ✔️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is cleaning up page layout related components. This includes:
AppWithExtendedSearchBarcomponent)PageContentLayoutcomponent which provides the page padding, grid and footer. This component replacesAppContentGridandAppWithoutSearchBar./extendedsearchIn general the markup and styling is now simpler, but I had one problem with the search page were I have to use
calc()in one case. I could not find a more flexible solution.I've tested these changes with Chrome, Safari and Firefox.
Types of changes