Skip to content

Include all file extensions in lint runs.#9996

Merged
linuspahl merged 1 commit intomasterfrom
include-file-extensions-for-eslint
Feb 2, 2021
Merged

Include all file extensions in lint runs.#9996
linuspahl merged 1 commit intomasterfrom
include-file-extensions-for-eslint

Conversation

@dennisoelkers
Copy link
Copy Markdown
Member

@dennisoelkers dennisoelkers commented Feb 1, 2021

During the centralisation of the jest config module (#9548), we removed the --ext parameter to eslint in our yarn script definitions. Unfortunately, this makes eslint to lint .js, .ts & .tsx files only, due to eslint using js per default and merging it with ts/tsx from the overrides section of the eslint-config-graylog module.

In order to include jsx files again, this PR adds an empty overrides section including js & jsx explicitly to the eslint-config-graylog module.

@dennisoelkers dennisoelkers force-pushed the include-file-extensions-for-eslint branch from 0b2fa66 to 508c24a Compare February 1, 2021 16:16
Copy link
Copy Markdown
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@linuspahl linuspahl merged commit d2d9efb into master Feb 2, 2021
@linuspahl linuspahl deleted the include-file-extensions-for-eslint branch February 2, 2021 10:51
bernd added a commit that referenced this pull request Mar 20, 2025
The ObjectMapperModule needs the chaining class loader to find classes
from plugins.

This broke in the node types refactoring in pull request #20181.
(commit b4e1e07)

Fixes #9768
Fixes #9996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants