Open
Conversation
Corrected incorrect spacing issues in a couple of files. Added data types for all parameters for all classes. Added documentation for all parameters. Removed anchor tags and replaced with require parameters where appropriate.
As part of fixing all PDK warnings, I realized that PDK was warning that the module needed to be updated to the newer version of PDK.
Member
|
@avitacco Hey! Can you fix the conflicts and the test errors? Thank you! 🙏 |
Adding a dependency for the package for the configuration file since the directory doesn't exist unless the package is installed. Also added a test to ensure that the dependency exists. Finally, changed some stdlib function calls to use the newer namespaced names.
Contributor
Author
|
@bernd I just wanted to give a quick update on this. My work is currently crazy and taking up all of my time. I have not forgotten about this PR or any of my other plans. I don't have the time right now, but hopefully soon. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all of the warnings from
pdk validaterelated to this module. It is mostly documentation and spacing changes, but several code changes had to be made. The main thing is the removal of all of the anchor resources in favor ofrequireparameters. This PR also updates the version of PDK used from 3.0 to 3.4.Notes for Reviewers