bug in ArrowRead.R

[haibol2016]

Lines 786 and 801 in https://github.com/haibol2016/ArchR/blob/master/R/ArrowRead.R,

if(!all(cellNames %in% colnames(mat))) should be be changed to if(!all(colnames(mat) %in% cellNames))

I am not sure why it is necessary to check this condition, because the random sampling is done using cellNames as the universal.

[rcorces]

Thanks for reporting. Apologies for my previously deleted post. I got confused by your link.
In the future, you can use permalinks to point directly to specific lines in the ArchR codebase.

For ex.

ArchR/R/ArrowRead.R

Line 786 in 6765ad9

if(!all(cellNames %in% colnames(mat))){

rather than pointing to your forked version.

I do believe this suggestion is correct. Though I think this only manifests as a bug at the line shown above (786) because the matrix has been subsampled so not all cellNames are in the colnames. So I havent changed it at line 801.

This has been patched in release_1.0.2 via 7554417

Feel free to comment again here as needed.

[rcorces]

Not my best work on this. I wasnt paying attention to my branch. This suggestion has already been fixed in release_1.0.2:

ArchR/R/ArrowRead.R

Line 792 in b2f3d95

if(!all(sampledCellNames %in% colnames(mat))){

I inadvertently was looking at master so I reverted that previous change.