Use dedicated properties file for buildscript #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
buildscript.properties, and move allgradle.propertiesonly used in thebuild.gradlefile into the new file.build.gradle.org.gradle.logging.stacktraceandorg.gradle.jvmargs.modNameandmodGroup.modId, as it incorrectly stated that the it was "convention" to be all lowercase instead of a requirement, seeFMLModContainer#sanityCheckModIdthrowingIllegalArgumentException, preventing it a mod from being loaded inModContainerFactory#build.gradle.propertiesfile to instead indicate thebuildscript.propertiesfile.reasoning:
build.gradleinto their own dedicated file, ensuring they dont pollute the global configs.potential concerns:
buildscript.propertiesfile isnt found, and single error will be noted, but loading will continue.gradle.propertiesare loaded in every file, them not being moved doesnt cause any issues.gradle.propertiesfile is non-viable due to breaking custom gradle properties.PR review considerations:
buildscript.properties- iebuild.properties.