Skip to content

Conversation

@serenibyss
Copy link
Member

Allows for Output Hatches to lock their fluids. Tested a few scenarios:

  • 1 Output Hatch locked to the correct fluid for a recipe works properly (runs as normal)
  • 1 Output Hatch locked to the incorrect fluid for a recipe works properly (does not run)
  • In the above scenario, when the lock is removed, the recipe works properly immediately (starts running, i.e. notifies the controller)
  • 2 Output Hatches locked to the correct fluids works properly (runs as normal)

I also tested a more complex scenario:

  1. Add 1 Output Hatch, locked to the desired Fluid.
  2. Enable "Void Fluids" on the multiblock
  3. Run a recipe that outputs 2 Fluids
  4. Multiblock will run, outputting only the desired fluid.
  5. This can be combined with a Fluid Detector Cover + Machine Controller Cover to automatically void an undesired Fluid, and shut off the multiblock if the desired Fluid's Hatch fills

@serenibyss serenibyss added the type: feature New feature or request label May 7, 2023
@ghzdude
Copy link
Contributor

ghzdude commented Jun 23, 2023

I've found an issue where the LCR, while running the ethylbenzene => styrene + hydrogen recipe, voids the output fluids after having the two lv output hatches filtered to styrene (top) and hydrogen (bottom) and then removing the filter on both hatches.

image

Then, trying to use the filter button would indicate that the LCR is trying to output hydrogen to the top output hatch and styrene to the bottom output hatch, but the output hatches are not filled even when they are unfiltered. Filtering one of the hatches to the correct fluid makes the LCR invalidate, and setting both of the hatches to be filtered makes them output fluid correctly.

EDIT: removing the super/quantum tank makes the output hatches properly fill, so it seems it's the insertion into the super/quantum tank that voids the output fluid.

I think the issue is actually with the super/quantum tank, which seems to void if the locked fluid button is disabled. Enabling locked fluid on the super/quantum tank makes the LCR fill correctly.

@serenibyss serenibyss force-pushed the ds-filtered-fluid-hatches-2 branch from 8592a86 to a6f942b Compare June 25, 2023 07:28
@serenibyss serenibyss requested a review from a team as a code owner June 25, 2023 07:28
@serenibyss serenibyss merged commit f273bc3 into master Jul 8, 2023
@serenibyss serenibyss deleted the ds-filtered-fluid-hatches-2 branch July 8, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants