Add Chemical Dyes and Recipes #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruberu
reviewed
Nov 20, 2021
Member
bruberu
left a comment
bruberu
left a comment
There was a problem hiding this comment.
There are a few things I would like to see changed in this PR, although it seems pretty good to me otherwise.
src/main/java/gregtech/loaders/recipe/VanillaStandardRecipes.java
Outdated
Show resolved
Hide resolved
TechLord22
force-pushed
the
dye-recipes
branch
from
bbb3c8b to
73d09b4
Compare
serenibyss
reviewed
Nov 20, 2021
src/main/java/gregtech/api/unification/material/materials/UnknownCompositionMaterials.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/loaders/recipe/chemistry/ReactorRecipes.java
Outdated
Show resolved
Hide resolved
TechLord22
force-pushed
the
dye-recipes
branch
from
e7aa620 to
6e34fcb
Compare
serenibyss
approved these changes
Nov 20, 2021
bruberu
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds chemical dyes, their production, production of the dye MetaItems, and adds recipes using them for vanilla items. It also adds a new config for removal of dying recipes.