Topic Support for Bot, resolves #649#662
Open
KMohZaid wants to merge 2 commits intoGreyWolfDev:betafrom
Open
Conversation
1. added `/setgrouptopic` command which admin can use to set/unset group topic for werewolf bot 2. added new column in `dbo.Group` table : `GroupTopicId` to store topic id 3. restricts bot command to specified topic only, except admin command and manually allowed command with Attribute `AllowOutsideConfiguredTopic` Note : I may have forget some places to update and make topic support
Author
|
this is new PR, as i messed up old one
note that i have squashed those 2 commit :
|
Author
|
Those 2 TODO are left(but planned, unrelated to this PR) :
|
Olgabrezel
requested changes
Jun 23, 2025
Collaborator
Olgabrezel
left a comment
Olgabrezel
left a comment
There was a problem hiding this comment.
Hi, thank you for the pull request!
I left some review comments, I think some parts of the design should be improved before we merge this.
If you could take a look at this, it would be highly appreciated!
In case of questions, just comment here, or ask on Support, whichever seems more appropriate!
Werewolf for Telegram/Werewolf Control/Commands/AdminCommands.cs
Outdated
Show resolved
Hide resolved
Werewolf for Telegram/Werewolf Control/Commands/AdminCommands.cs
Outdated
Show resolved
Hide resolved
Werewolf for Telegram/Werewolf Control/Handlers/UpdateHandler.cs
Outdated
Show resolved
Hide resolved
Werewolf for Telegram/Werewolf Control/Handlers/UpdateHandler.cs
Outdated
Show resolved
Hide resolved
Werewolf for Telegram/Werewolf Control/Handlers/UpdateHandler.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
(I should note, I have not tried to execute the code to test its functional correctness so far. These are all just my thoughts based on reading it.) |
Olgabrezel
changed the title
Author
|
I will work on reviews when I get time. Thank you for feedback |
Author
|
@Olgabrezel check new commit and tell me if there is anything needed to be done |
KMohZaid
commented
Jun 26, 2025
Comment on lines
+2272
to
+2285
|
|
||
| <string key="SetTopicCmdNotInGeneral"> | ||
| <value>❌ You must run this command inside a topic/thread (not the general topic).</value> | ||
| </string> | ||
| <string key="SetTopicSuccess"> | ||
| <value>✅ Group topic has been set successfully.</value> | ||
| </string> | ||
| <string key="UnsetTopicSuccess"> | ||
| <value>🗑️ Group topic has been unset.</value> | ||
| </string> | ||
|
|
||
| <string key="MustRunInConfiguredTopic"> | ||
| <value>This command can only be used in the configured topic/thread. (Topic id : {0})</value> | ||
| </string> |
Author
There was a problem hiding this comment.
oops, forget to format it to proper indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/setgrouptopiccommand which admin can use to set/unset group topic for werewolf botdbo.Grouptable :GroupTopicIdto store topic idAllowOutsideConfiguredTopicNote : I may have forget some places to update and make topic support
This PR resolves :
#649