Skip to content

build: Use dace release package from pypi#2600

Merged
edopao merged 4 commits into
GridTools:mainfrom
edopao:dace_switch_to_pypi_release
May 19, 2026
Merged

build: Use dace release package from pypi#2600
edopao merged 4 commits into
GridTools:mainfrom
edopao:dace_switch_to_pypi_release

Conversation

@edopao
Copy link
Copy Markdown
Contributor

@edopao edopao commented May 12, 2026

  • Use same dace version for GT4Py cartesian and next.
  • Make dace a GT4Py dependency, and remove the development groups dace-cartesian and dace-next.
  • Instead of using the gridtools package index, pull the dace pre-release package from PyPI index.

Note: if in the future a custom (non-pypi) version is needed, cartesian and next need to create a version from a common branch (and publish to the gridtools index).

Copy link
Copy Markdown
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not sure if we should give up the index yet.
Because as soon as we need a special PR or so for DaCe we are back to the same solution as before.
For example we can not use the new GPU codegen until that is merged, which will take a long time.

Another question is what should happen with the GT4Py PyPI index?
This is also a question should we remove the entry from the pyproject.toml?

Maybe @egparedes you have some opinions on that.

Comment thread pyproject.toml Outdated
@@ -485,8 +485,7 @@ url = 'https://gridtools.github.io/pypi/'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left this example as a reference in case we need to pull from the gridtools index.

Copy link
Copy Markdown
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread pyproject.toml
Comment on lines +475 to 478
# Add the uv source below to pull dace from the gridtools index instead of PyPI:
# dace = {index = "gridtools"}
[tool.uv.sources]
atlas4py = {index = "test.pypi"}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add the uv source below to pull dace from the gridtools index instead of PyPI:
# dace = {index = "gridtools"}
[tool.uv.sources]
atlas4py = {index = "test.pypi"}
[tool.uv.sources]
atlas4py = {index = "test.pypi"}
# Add the uv source below to pull dace from the gridtools index instead of PyPI:
# dace = {index = "gridtools"}

nit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but the TOML formatter will delete the comment lines inside the tool.uv.sources section.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there something like noqa: for the toml formatter?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but did not succeed.

@havogt havogt requested review from FlorianDeconinck and romanc May 18, 2026 11:30
Copy link
Copy Markdown
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanc romanc changed the title build[next]: Use dace release package from pypi build: Use dace release package from pypi May 19, 2026
@edopao edopao merged commit 76c1e3e into GridTools:main May 19, 2026
32 checks passed
@edopao edopao deleted the dace_switch_to_pypi_release branch May 19, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants