fix[next]: cache dir construction and translation_cache lifetime#2604
Merged
Conversation
edopao
approved these changes
May 20, 2026
Contributor
edopao
left a comment
edopao
left a comment
There was a problem hiding this comment.
I am approving this PR because it fixes a problem. My comment is just a discussion point, how we want to setup the persistent cache for different backends.
| cache=filecache.FileCache( | ||
| str( | ||
| cache.get_cache_base_path(config.BUILD_CACHE_LIFETIME) | ||
| / "translation_cache" |
Contributor
There was a problem hiding this comment.
Do we need to use dace_cache (similarly to what the gtfn backend does, gtfn_cache) to be able to share the cache directory across backends?
Or, I believe, the backend key is already part of the translation hash and therefore different backends can coexist in the same translation folder?
tehrengruber
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translation_cache.