Language Selector AutogenerateLanguages fails to get neutral language

[537mfb]

when using:

<l:LanguageSelector AutogenerateLanguages="True" />

and having two languages (1 specific (resources.pt.resx) and a neutral (resources.resx)) only the specific one is shown.

The standard dictates that a line similar to:

[assembly: NeutralResourcesLanguage("en-US", UltimateResourceFallbackLocation.MainAssembly)]

should be added to Assembly.cs but the language selector ignores it and ignores the neutral languages that serves as a fallback when a specific resource for the culture is missing

[JohanLarsson]

Thanks for reporting! Do you want to have a go at fixing it?
If you need a quick fix you can wire up languages explicitly like this

[JohanLarsson]

@537mfb If you have time you can review the diff.
I'm releasing an updated nuget now, if you find errors we release another one.

[537mfb]

Hi @JohanLarsson - sorry for the late reply - i am away for hollydays right now
i'll see about testing this today or tomorrow and get back to you

[JohanLarsson]

Nice, thanks!

[537mfb]

Hi @JohanLarsson

Just took a few moments to test this - and it's working - it gets the neutral language from the assembly and uses the base resx for it when that language is selected - perfect, no more duplicate resx files for neutral language

Improvement Notes:
When the assembly doesn't set a neutral (no [assembly: NeutralResourcesLanguage("en-US", UltimateResourceFallbackLocation.MainAssembly)] like line in assembly.cs or it's commented out), .NET assumes en-US as default - your library should assume en as default for this cases aswell - at the moment if the line is missing, your selector just shows the languages with satellite dlls as before

Notice i said your library should assume en and not en-US - when AutogenerateLanguages is set to true en-US doesn't show a flag while en does