Open
Conversation
added 3 commits
January 29, 2018 15:56
rae-ralston
reviewed
Jan 30, 2018
rae-ralston
left a comment
rae-ralston
left a comment
There was a problem hiding this comment.
Overall it's looking good. It's a little harder to do an in depth review because much of this was scaffolded by someone else. But the changes you've made here make sense, the naming conventions are much more self evident.
src/routes/review.js
Outdated
| userFunctions.getById(cityReviews.user_id) | ||
| .then((reviewer) => { | ||
| response.render('reviews/viewFull', { reviews: cityReviews, user: reviewer, city: true }); | ||
| response.render('reviews/FullUserReview', { reviews: cityReviews, user: reviewer, city: true }); |
There was a problem hiding this comment.
should this be a lower case F or uppercase on FullUserReview?
added 8 commits
January 30, 2018 13:40
…ic or definitions
…ic or definitions
…ic or definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monday's Completed Tasks