You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Offload websocket request rewrites from async worker
In src/proxy/websocket.rs (checked the websocket request path), rewrite_ws_request_text is called directly inside handle_message on the async task, but the new detector stack can invoke OpenAiCompatibleLocalClassifier::accept in src/sensitive.rs, which performs blocking reqwest::blocking network I/O. When the local classifier is enabled (or rewrite work is slow), this blocks a Tokio worker thread and can stall unrelated websocket/proxy traffic; the HTTP handler already avoids this by using spawn_blocking with a timeout.
Reintroduce a bounded scan for partial placeholders
find_partial_placeholder_start now reverse-scans the entire string (text.char_indices().rev()), and this function is called repeatedly from SSE chunk processing (SseStreamResolver::resolve_pending_text). For long input_json_delta streams that keep a placeholder-like tail unresolved, this turns into repeated full-buffer scans and can cause quadratic-time behavior and streaming latency spikes; the previous implementation bounded the scan to a small tail window.
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo build --lockedcargo test --lockedcargo test --locked --test e2e_cli -- --ignored --test-threads=1cargo doc --no-depsDocs
docs/updated if deeper reference material changedNotes