Skip to content

Codex/restart from 6f4bb98#71

Merged
GuthL merged 1 commit intomainfrom
codex/restart-from-6f4bb98
Mar 11, 2026
Merged

Codex/restart from 6f4bb98#71
GuthL merged 1 commit intomainfrom
codex/restart-from-6f4bb98

Conversation

@GuthL
Copy link
Owner

@GuthL GuthL commented Mar 11, 2026

Summary

  • Describe the change and the user or maintainer impact.

Validation

  • cargo fmt --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --locked
  • cargo test --locked
  • cargo test --locked --test e2e_cli -- --ignored --test-threads=1
  • cargo doc --no-deps

Docs

  • README updated if public behavior changed
  • docs/ updated if deeper reference material changed
  • Screenshots or SVG assets updated if the repo-facing experience changed

Notes

  • Call out risks, follow-ups, or release considerations here.

@GuthL GuthL changed the base branch from master to main March 11, 2026 15:55
@GuthL GuthL merged commit 8f13d7a into main Mar 11, 2026
@chatgpt-codex-connector
Copy link

💡 Codex Review

match self.rewrite_ws_request_text(text.as_str(), uses_input_only_ws_rewrite(ctx)) {

P1 Badge Offload websocket request rewrites from async worker

In src/proxy/websocket.rs (checked the websocket request path), rewrite_ws_request_text is called directly inside handle_message on the async task, but the new detector stack can invoke OpenAiCompatibleLocalClassifier::accept in src/sensitive.rs, which performs blocking reqwest::blocking network I/O. When the local classifier is enabled (or rewrite work is slow), this blocks a Tokio worker thread and can stall unrelated websocket/proxy traffic; the HTTP handler already avoids this by using spawn_blocking with a timeout.


text.char_indices().rev().find_map(|(abs, ch)| {

P2 Badge Reintroduce a bounded scan for partial placeholders

find_partial_placeholder_start now reverse-scans the entire string (text.char_indices().rev()), and this function is called repeatedly from SSE chunk processing (SseStreamResolver::resolve_pending_text). For long input_json_delta streams that keep a placeholder-like tail unresolved, this turns into repeated full-buffer scans and can cause quadratic-time behavior and streaming latency spikes; the previous implementation bounded the scan to a small tail window.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant