This repository was archived by the owner on Mar 12, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Migrate userXML to GrandMaster #219
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethcooper
suggested changes
Jan 25, 2017
Collaborator
sethcooper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Shouldn't we go into error if the CfgCVSBasePath or the MasterSnippet list can't be found (i.e., on catching an exception)? I don't really like relying on defaults, nor on just sticking a warning message in the log. Of which there are many already. Speaking of which...
- Please cut down on logger.info and logger.warn
- I don't really understand what the return "" are doing in the getHCALuserXMLelementContent and getNamedUserXMLelementAttributeValue functions
- Otherwise, assuming it's been tested, it seems fine
Collaborator
Author
|
|
Collaborator
Author
|
-Removed the unused special snippets filenames from userXML, e.g. #139 |
sethcooper
approved these changes
Jan 26, 2017
Closed
Collaborator
Author
|
Also closing #28 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #110
CfgCVSBasePathandMasterSnippetList(ie the file name of grandMaster) should remain in LV1's userXML.