Skip to content

Fix tethers not being edgehoggable#464

Merged
techyCoder81 merged 4 commits intodevfrom
issue-232-ledge-occupancy
May 13, 2022
Merged

Fix tethers not being edgehoggable#464
techyCoder81 merged 4 commits intodevfrom
issue-232-ledge-occupancy

Conversation

@black-calculus
Copy link
Copy Markdown
Collaborator

Resolves #439

Also readjusts the params on trump momentum and actionability to suit the more consistent behavior on when you get trumped, sending you less high and adding 5 frames of endlag.

@black-calculus black-calculus self-assigned this Apr 7, 2022
@black-calculus black-calculus added bug Something isn't working semver:feature labels Apr 7, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2022

Download the artifacts for this pull request:

@MadVillainLordQ
Copy link
Copy Markdown
Contributor

Fix works in almost every scenario except when tethered person grabs a frame on/after an opponent grabs ledge. The opponent on ledge is ledge trumped and placed in trump lag.

Possible explanation for trumping on the same frame is port priority but I could not test to make sure.

See discussion here:
https://discordapp.com/channels/659964948365049887/950979417004466196/961851691433594890

jobrien97
jobrien97 previously approved these changes Apr 8, 2022
Copy link
Copy Markdown
Collaborator

@jobrien97 jobrien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jobrien97 jobrien97 added engine For working on engine changes semver:patch bug Something isn't working and removed bug Something isn't working semver:feature labels Apr 8, 2022
@techyCoder81
Copy link
Copy Markdown
Collaborator

Does this fix appropriately handle ICs?

Copy link
Copy Markdown
Collaborator

@techyCoder81 techyCoder81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change does not correctly take ICs into account. This character's ledgehog has not functioned for 3 years and I would like to see it finally work at some point.

@techyCoder81
Copy link
Copy Markdown
Collaborator

techyCoder81 commented Apr 21, 2022

you can get the partner boma by using object.battle_object_id + 0x10000, such as

let partner_id = (popo_boma.object().battle_object_id + 0x10000);
let partner_object = unsafe { &mut *get_battle_object_from_id(partner_id) };

Copy link
Copy Markdown
Collaborator

@jobrien97 jobrien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya looks great FINALLY

@jobrien97 jobrien97 requested a review from techyCoder81 May 12, 2022 21:47
@techyCoder81 techyCoder81 merged commit 2344aa9 into dev May 13, 2022
SuddyN added a commit that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working engine For working on engine changes semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tether ledgetrump works the opposite way it's supposed to

5 participants