Add support for yoda-H5#899
Conversation
|
Two observations:
|
Hmm, strange, I don't see a reason for this and it might be a bug in the GitHub web interface. But maybe you can exploit the mirroring to avoid opening new PRs for #878 and #886 as long as the two branches are kept identical, then I could close this PR and merge the original PR #884 instead? Edit: actually, not sure this is a good idea and the
I re-ran the CI with the same result. All tests pass on the Not sure about the first failure, but for the second you need to modify |
|
|
The issue is that This was caused by the |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the YODA-H5 file format (yoda.h5) to the HEPData platform. YODA-H5 is a parallel computing-optimized variant of the YODA format for high-energy physics data.
- Add
.yoda.h5to supported file formats across download endpoints and configuration - Update documentation to describe the new format and its parallel computing benefits
- Add comprehensive test coverage for the new format in JSON-LD metadata generation
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hepdata/config.py | Add yoda.h5 to supported formats list |
| hepdata/modules/converter/views.py | Update routes and documentation to support yoda.h5 format |
| hepdata/modules/records/utils/data_processing_utils.py | Refactor URL generation to include yoda.h5 format |
| hepdata/modules/records/utils/json_ld.py | Add yoda.h5 to JSON-LD metadata format mappings |
| hepdata/ext/opensearch/document_enhancers.py | Include yoda.h5 in search document URL generation |
| hepdata/modules/theme/templates/hepdata_theme/pages/formats.html | Update documentation with yoda.h5 format description |
| tests/records_test.py | Add test case for yoda.h5 in JSON-LD metadata |
| tests/e2e/test_general.py | Add end-to-end test coverage for yoda.h5 format |
| hepdata/version.py | Bump development version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@codecov-ai-reviewer review |
This comment has been minimized.
This comment has been minimized.
* Implement suggestion from review by Codecov AI.
|
@codecov-ai-reviewer test |
|
On it! Codecov is generating unit tests for this PR. |
|
@codecov-ai-reviewer test |
|
On it! Codecov is generating unit tests for this PR. |
Ah, I somehow completely missed that error. Thanks a lot for fixing the problem! |
Replacement of #884 to make the CI run properly.
The changes of this PR are
.yoda.h5in supported file formats for download requests/urls..yoda.h5.Add yoda-hdf5 support hepdata-converter#64 (comment), this does not add
.yoda.h5to the dropdown menus.