This repository was archived by the owner on Apr 2, 2025. It is now read-only.
Merge pull request #497 from HPCToolkit/rocprofiler_support#537
Merged
jmellorcrummey merged 2 commits intomasterfrom Mar 28, 2022
Merged
Merge pull request #497 from HPCToolkit/rocprofiler_support#537jmellorcrummey merged 2 commits intomasterfrom
jmellorcrummey merged 2 commits intomasterfrom
Conversation
This is a huge merge to develop. It includes three main components: 1. Preliminary rocprofiler support for getting AMD GPU hardware counters. 2. Prelminary support for AOMP (AMD's openmp implementation). 3. Breakdown of hpcrun initialization and reordering. (cherry picked from commit 627d4da)
| int verbose | ||
| ); | ||
|
|
||
| #if defined(__cplusplus) |
Member
There was a problem hiding this comment.
This if defined(__cplusplus) should be deleted. It is an unmatched duplicate inside an if 0. The whole if 0 can be deleted if you choose.
| AC_SUBST([OPT_GTPIN_LIBDIR]) | ||
|
|
||
|
|
||
| #------------------------------------------------- |
Member
There was a problem hiding this comment.
remove redundant copies of --with-igc, with-metrics-discovery, with-gtpin
jmellorcrummey
approved these changes
Mar 28, 2022
Member
jmellorcrummey
left a comment
jmellorcrummey
left a comment
There was a problem hiding this comment.
The PR is OK. There is a bit of redundant code (e.g. in configure.ac). There is some unused code (the gpu_monitor layer) and the hip_api layer. However, our plan is to clean this up in develop rather than worry about it here. Master will soon be replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally merged to the develop branch and it is now cherry-picked to master so that we can do a release for AMD platforms. This seems to work reasonably well on Crusher using rocm-5.0.2 with the matrix multiplication test. Original PR message below:
This is a huge merge to develop . It includes three main components:
(cherry picked from commit 627d4da)