67444 Refactor cache boostrapper #61
Conversation
| int lookupCounter = 0; | ||
| int rowCounter = 0; | ||
| @Override | ||
| String getQuery() { |
There was a problem hiding this comment.
Just moved above and removed the redundant string builder.
The order of methods definition follows the order of steps executed by the processor:
getting query
collecting results
processing them
| resultSet.getString(queryUtils.START_TIME))); | ||
| } | ||
|
|
||
| log.info("[OPTIMIZED] Database query found {} rows", journeyResultItems.size()); |
There was a problem hiding this comment.
this was moved to the main QueryProcessor, both the log line and closing the query
| log.error("Unknown exception during query ", e); | ||
| log.info("All data processed"); | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
propagating the error so the job execution would be marked as failed and retried.
|
|
||
| public static void main(String[] args) { | ||
| String connectionString = ""; | ||
| var jobId = randomUUID().toString(); |
There was a problem hiding this comment.
so we can correlate in the central logging system all the logs for a given run
| import static fi.hsl.common.transitdata.TransitdataProperties.formatMetroId; | ||
| import static fi.hsl.transitdata.pubtransredisconnect.MetroJourneyResultSetProcessor.MetroJourneyResultItem; | ||
|
|
||
| public class MetroJourneyResultSetProcessor extends AbstractResultSetProcessor<MetroJourneyResultItem> { |
There was a problem hiding this comment.
migrating this processor to the same logic of:
executing query
collecting results
closing query
processing items
| public class StopResultSetProcessor extends AbstractResultSetProcessor { | ||
| import static fi.hsl.transitdata.pubtransredisconnect.StopResultSetProcessor.StopResultItem; | ||
|
|
||
| public class StopResultSetProcessor extends AbstractResultSetProcessor<StopResultItem> { |
There was a problem hiding this comment.
migrating this processor to the same logic of:
executing query
collecting results
closing query
processing items
No description provided.