Merged
Conversation
paasovaara
approved these changes
Mar 19, 2019
paasovaara
left a comment
paasovaara
left a comment
There was a problem hiding this comment.
Looks good.
We don't necessarily need to update all the java-files, just the src/main/java/com/google/transit/realtime/GtfsRealtime.java should be enough. shouldn't hurt either though.
Contributor
Author
|
There are lots of changes made by the generator. Are they safe? |
@kenkus-futurice most likely different versions of protoc will generate a bit different boilerplates. this should not be a problem but it might be safer just to leave the other files as they were. |
…o schemas" This reverts commit 5bfcf8b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gfts-realtime.proto has been merged:
google/transit#136
GtfsRealtime.java is still WIP:
MobilityData/gtfs-realtime-bindings#43