Fixing Redis breaking change #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserting Hydra Core and Open Parser since Hydrus ported Hydraspec
Adding import to hydra_python_core after hydraspec porting
Backwards incompatibility from Redis 2 to Redis 3, which now only accepts values as bytes, strings or numbers
Changing this test slightly so the "requirements.txt" consists of everything needed to run and it won't fail because of the requirements in the current hydrus master branch.
gustavodemorais
changed the title
The goal of Porting the doc writer was so that the agent supposed to depend only on hydra_python_core which is now possible.
shravandoda
reviewed
Mar 3, 2019
Contributor
shravandoda
left a comment
shravandoda
left a comment
There was a problem hiding this comment.
I don't think we need doc_maker in hydra_graph. But apart from that it looks good
Use 'hydra_python_core' module in place of 'hydrus.hydraspec'
xadahiya
reviewed
Mar 3, 2019
| import json | ||
| from hydrus.hydraspec import doc_maker | ||
| import hydra_python_core | ||
| from hydra_python_core import doc_maker |
Member
There was a problem hiding this comment.
Don't need both these imports. You can either import hydra_python_core and use hydra_python_core.doc_maker or import dic_maker directly. I don't see the reason to do both
Contributor
Author
There was a problem hiding this comment.
You are right. Already fixed and re-based according to @de-sh commit.
Contributor
Backwards incompatibility from Redis 2 to Redis 3, which now only accepts values as bytes, strings or numbers
gustavodemorais
changed the title
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 86
Checklist
Description
Setting Redis version as 2 because of breaking change in Redis 3
Change logs
Fixed
redis.exceptions.DataError: Invalid input of type: 'dict'. Convert to a byte, string or number first.
(redis_connection.set("EntryPoint", entrypoint_properties)...)
Set Redis version because of backwards incompatibility from Redis 2 to Redis 3, which now only accepts values as bytes, strings or numbers.