feat: remove selected_place from job results#11
Merged
Conversation
1000hyehyang
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 무엇을 바꿨나요?
selected_place단일 필드를 제거하고, 장소 선택 결과를selected_places배열 기준으로 일원화했습니다.🔗 관련 이슈
Closes #10
💡 왜 바꿨나요?
다중 장소 추출 구조에서는
selected_places가 실제 source of truth입니다.selected_place는 기존 단일 장소 스키마 호환용으로 남겨둔 필드였지만, 팀 논의 결과 더 이상 유지할 필요가 없어 제거했습니다.📝 주요 변경 사항
job_results.selected_place컬럼 제거 migration 추가selected_place제거selected_place제거selected_places기준으로 정리selected_places기준으로 수정👀 리뷰어가 보면 좋은 부분
selected_place만 제거되고, 단일/다중 장소 결과는 모두selected_places에 배열로 유지됩니다.selected_places에 1개 저장selected_places에 여러 개 저장🧪 테스트
방식 (해당하는 것만 체크)
메모 (시나리오, 커맨드, 스크린샷 링크 등 — 선택)
python -m compileall app.venv\Scripts\python.exe -m pytest -q57 passed, 1 skippedselected_places_count = 6selected_places_count = 1selected_placekey 없음