Skip to content

fix hero loading state #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michelleyeoh merged 3 commits into from
Mar 8, 2026
Merged

fix hero loading state #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
834416a
fix hero loading state
michelleyeoh Mar 8, 2026
34a9c80
simplify countdown check
michelleyeoh Mar 8, 2026
d149459
added comments
michelleyeoh Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions app/(pages)/(hackers)/_components/HomeHacking/HeroHacking.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import Image from 'next/image';
import { GoArrowRight } from 'react-icons/go';

import ClientTimeProtectedDisplay from '@pages/_components/TimeProtectedDisplay/ClientTimeProtectedDisplay';
import Countdown from './_components/Countdown';

interface HeroHackingProps {
Expand All @@ -17,6 +15,7 @@ export default function HeroHacking({
rolloutTime,
loading,
}: HeroHackingProps) {
// Adds one day to rollout time 'hacking-starts' AKA hacking ending time
const countdownTarget = rolloutTime ? rolloutTime + ONE_DAY_MS : undefined;

return (
Expand Down Expand Up @@ -45,18 +44,10 @@ export default function HeroHacking({
<div className="flex items-start justify-between gap-2">
{/* Right: countdown (big) */}
<div className="flex-1 flex justify-center">
<div className="text-white">
<ClientTimeProtectedDisplay
featureId="hacking-starts"
fallback={<Countdown />}
>
{countdownTarget !== undefined && (
<Countdown countdownTarget={countdownTarget} />
)}
</ClientTimeProtectedDisplay>

<div className="text-white relative">
<Countdown countdownTarget={countdownTarget} />
{loading && (
<div className="mt-2 text-white/90 text-sm text-right">
<div className="absolute top-full mt-2 text-white/90 text-sm">
loading…
</div>
)}
Expand Down
4 changes: 2 additions & 2 deletions app/(pages)/(hackers)/_components/HomeHacking/_components/Countdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ interface CountdownProps {
countdownTarget?: number;
}

const HACKING_ENDS_TIME = new Date('2026-05-10T11:00:00-07:00').getTime(); // May 10, 2026 at 11:00 AM PDT
const FALLBACK_HACKING_ENDS = new Date('2026-05-10T11:00:00-07:00').getTime(); // May 10, 2026 at 11:00 AM PDT

export default function Countdown({
countdownTarget = HACKING_ENDS_TIME,
countdownTarget = FALLBACK_HACKING_ENDS,
}: CountdownProps) {
const [timeLeft, setTimeLeft] = useState({
hours: 24,
Expand Down