Refactor submission router to routes folder #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi Alan, can you edit the file like this example Specifically, just leave the router without any content inside the brackets |
Collaborator
longtran1904
left a comment
longtran1904
left a comment
There was a problem hiding this comment.
Hi Alan, please check out the comments
server/router/submission.route.js
Outdated
| * tags: | ||
| * - submissions | ||
| */ | ||
| router.get('/', async ({ res }) => { |
Collaborator
There was a problem hiding this comment.
In Router folder, we just specify the route we want to export, for example
router
.route('/:userId')
.get(userController.getUser);
So you can drop the async promises and left it blank.
Do the rest for the other functions and it would be fine.
server/router/submission.route.js
Outdated
| * tags: | ||
| * - submissions | ||
| */ | ||
| router.get('/:submissionID', async (req, res) => { |
Collaborator
There was a problem hiding this comment.
For example,
You can just leave the code:
router.get('/:submissionId', /* call function to get submissionID here */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisson.js in routes folder now.