Skip to content

feat: editable profiles#100

Merged
saheeen-jey merged 26 commits intomainfrom
editable-profiles_
Nov 23, 2023
Merged

feat: editable profiles#100
saheeen-jey merged 26 commits intomainfrom
editable-profiles_

Conversation

@martin0024
Copy link
Copy Markdown
Contributor

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
track-the-hack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 0:02am

@martin0024 martin0024 requested a review from arcanistzed October 2, 2023 04:13
Comment thread src/pages/hackers/hacker.tsx Outdated
@martin0024
Copy link
Copy Markdown
Contributor Author

Seems like there is a problem with the pattern system.
ESLint: Unsafe assignment of an any value. (@typescript-eslint/no-unsafe-assignment)
ESLint: Unsafe member access .toString on an any value. (@typescript-eslint/no-unsafe-member-access)

Copy link
Copy Markdown
Member

@arcanistzed arcanistzed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please format this with npm run format.
Also, please localize all user-facing text, such as the text on the button to save changes or the label for uploading a resume.

Important to note that the resume uploading button doesn't do anything currently, and that's okay for the initial version. @Ryan-Awad is going to work on adding the resume upload functionality using Amazon S3.

@martin0024
Copy link
Copy Markdown
Contributor Author

Looks great! Please format this with npm run format. Also, please localize all user-facing text, such as the text on the button to save changes or the label for uploading a resume.

Important to note that the resume uploading button doesn't do anything currently, and that's okay for the initial version. @Ryan-Awad is going to work on adding the resume upload functionality using Amazon S3.

Perfect, thanks, Ryan, don't hesitate if you have any questions.
I will commit the npm run format

@arcanistzed arcanistzed mentioned this pull request Oct 16, 2023
@martin0024
Copy link
Copy Markdown
Contributor Author

Awaiting feedback on every section of the user's profile and also the colors.

@saheeen-jey
Copy link
Copy Markdown
Contributor

saheeen-jey commented Oct 18, 2023

Looks good! Looked at some of the fields and saw there wasn't validation on some of the form fields and some of the inputs should be dropdown menus as there are limited to a specifc set of strings.

  • Email should have email validation using type=email
  • Phone number should only have number input
  • Walkin, Subscribe to mailing list, and Transportation should be dropdowns of true or false
  • Attendance type should be a drop down of [IN_PERSON or ONLINE]

@saheeen-jey
Copy link
Copy Markdown
Contributor

The colour looks good for now, it will need to be re-coloured but that will be changed with the CSS variables

@saheeen-jey saheeen-jey merged commit 2bc3e47 into main Nov 23, 2023
csong202 pushed a commit that referenced this pull request Nov 26, 2023
@arcanistzed arcanistzed deleted the editable-profiles_ branch July 5, 2024 11:46
arcanistzed pushed a commit that referenced this pull request Jul 5, 2024
mixtapeo pushed a commit that referenced this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants