Fix date-picker confusing American date format #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choosing a date with the calendar button, the selected date was hard-coded with "." as delimiter as "day.month.year". The later parsing interpreted this as "month/day/year" when the locale is set to e.g. US American. This fixes that by creating the date string according to the current locale. It's not really satisfying - as the whole date-handling back-forth between BDate and strings of the whole app feels wasteful... OTOH, adding another locale conversion here isn't that bad, as it's only invoked once for the date chosen in the calendar window... Fixes HaikuArchives#129
Contributor
|
LGTM |
Member
Author
|
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choosing a date with the calendar button, the selected date was hard-coded with "." as delimiter as "day.month.year". The later parsing interpreted this as "month/day/year" when the locale is set to e.g. US American.
This fixes that by creating the date string according to the current locale. It's not really satisfying - as the whole date-handling back-forth between BDate and strings of the whole app feels wasteful... OTOH, adding another locale conversion here isn't that bad, as it's only invoked once for the date chosen in the calendar window...
Fixes #129