Fix part of #5 - Finder parameter must be an array#6
Open
vukanac wants to merge 3 commits intoHalleck45:masterfrom
Open
Fix part of #5 - Finder parameter must be an array#6vukanac wants to merge 3 commits intoHalleck45:masterfrom
vukanac wants to merge 3 commits intoHalleck45:masterfrom
Conversation
…array * Hal/Component/Finder has changed constructor and now accepts array * Finder has removed method and introduced instead - required CLI argument for path to be changed in array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With old
composer.jsonlatestphpmetricswas installed and it has the constructor with different parameters. We have to convert accepting argument and options in CLI command from string to array.Hal/Component/Finderhas changed constructor and now accepts array - require options for include and exclude to be arraysFinderhas removed method and introduced instead - required CLI argument for the path to be changed in the array.Small note:
Tokenizerfromphpmetricsa new bug show up.I hope that that new bug is not a constraint for this pull request.