Skip to content

Merge changes from my fork back to main Repo#352

Closed
oformaniuk wants to merge 64 commits intoHandlebars-Net:masterfrom
oformaniuk:back-merge
Closed

Merge changes from my fork back to main Repo#352
oformaniuk wants to merge 64 commits intoHandlebars-Net:masterfrom
oformaniuk:back-merge

Conversation

@oformaniuk
Copy link
Member

@oformaniuk oformaniuk commented May 31, 2020

What's inside (inspired by /issues/294):

Due to the nature and amount of changes I'm not able to extract them to a separate PRs one for each issue at this point.
I'd continue to support my fork (and back-port changes here) until the PR is merged.

oformaniuk and others added 30 commits March 15, 2020 10:55
Added support for helpers with return statement
Refactored expression tree creation to improve readability and maintainability
- Use `ObjectPool` from NuGet
- Repack of IL to prevent additional dependencies
- Path segment proper caching
- Add test coverage
 Extreme refactoring/enhancements (aka v2.0)
oformaniuk and others added 24 commits May 18, 2020 05:55
Fix `value` variable leaking from `BindingContext`
- do not use ILRepack as it's not working with Unix
- use proper settings
- fix CompileFast extension for Unix
- fix closure extraction for ValueTypes
- obsolete code cleanup
@jrlost
Copy link

jrlost commented Jul 20, 2020

Can we get more eyes on this? @zjklee your performance enhancements alone warrant a strong consideration for merging this. We are actively using the fork on some high traffic sites and have seen massive improvements to compile time and allocations (and the related reduction in heap size and GCs). I'm talking orders of magnitude improvements. I cannot personally speak to any of the other functionality changes as we're not actively using them, but the compile and runtime improvements are great.

My only issue is that I'm forced to pull a separate nuget repository to run it, which has a separate token, so I cannot just update in-place; I'm forced to drop this repos package, add the package from the fork, update references, etc... Then once this gets merged, if it does, I need to undo all of that.

@Badabum
Copy link

Badabum commented Jul 31, 2020

@rexm any chance you'll have time to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants