Add more tests #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I think I also messed up something when trying to rebase... I'll fix this later, but just wanted to put this out. |
SuperCl4sh
force-pushed
the
flexibleunpickledev
branch
from
5769e9e to
641eb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR that adds more tests. Don't merge this yet, we can discuss some things tomorrow. Just wanted to put this here so you can see the tests beforehand. The problematic (I think?) test is on line 98
J is defined in Unsafe_1 and K extends it (in Flexible_2), so I believe this should not compile (since null is not a valid value of K) but it currently does.
Edit: Nevermind, I don't think this is a bug because List is in the stl and compiled without -Yexplicit-nulls.