Skip to content

Do not DeepCopy() in Reconcile(), as controller-runtime already did it for us #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Harwayne merged 1 commit into from
Mar 18, 2019
Merged

Do not DeepCopy() in Reconcile(), as controller-runtime already did it for us #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/reconciler/v1alpha1/broker/broker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func (r *reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
r.recorder.Event(broker, corev1.EventTypeNormal, brokerReconciled, "Broker reconciled")
}

if _, err = r.updateStatus(broker.DeepCopy()); err != nil {
if _, err = r.updateStatus(broker); err != nil {
logging.FromContext(ctx).Error("Failed to update Broker status", zap.Error(err))
r.recorder.Eventf(broker, corev1.EventTypeWarning, brokerUpdateStatusFailed, "Failed to update Broker's status: %v", err)
return reconcile.Result{}, err
Expand Down
3 changes: 0 additions & 3 deletions pkg/reconciler/v1alpha1/trigger/trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ func (r *reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
return reconcile.Result{}, err
}

// Modify a copy, not the original.
trigger = trigger.DeepCopy()

// Reconcile this copy of the Trigger and then write back any status updates regardless of
// whether the reconcile error out.
reconcileErr := r.reconcile(ctx, trigger)
Expand Down