add additional import alias for newer GHC versions#124
Merged
Conversation
|
The generated modules now make Just out of curiosity, why is this the preferred solution? Wouldn't another solution be to not access the GHC internal namespace at all and use |
Member
Author
|
@schoettl We use template-haskell for the code generation and it seems like even if you do not access internal modules during the generation, they can still get exposed in the actually generated code. I assume this is due to the fact that template-haskell is not designed for code generation written to file but instead for ad-hoc generation during compilation where these quirks are internals of the compiler. |
|
Ah, makes sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #123