Implement review feedback for #131#132
Open
mjgpy3 wants to merge 2 commits intoHaskell-OpenAPI-Code-Generator:masterfrom
Open
Implement review feedback for #131#132mjgpy3 wants to merge 2 commits intoHaskell-OpenAPI-Code-Generator:masterfrom
mjgpy3 wants to merge 2 commits intoHaskell-OpenAPI-Code-Generator:masterfrom
Conversation
|
NixCI is ready to run on this PR. |
Member
|
Thank you for the additions 👍 |
Contributor
|
nix-ci run |
|
NixCI started a suite, more details are available here. |
Contributor
Author
Whoops! I had them working, maybe something about my setup is wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does a couple of things
The level3 tests are AI slop (I'm sorry). I reviewed them and the seem decent enough.
The comments are boutique, written by yours truly.