(WIP) Support for providing of parameters at path level and overriding them…#71
Closed
portnov wants to merge 1 commit intoHaskell-OpenAPI-Code-Generator:masterfrom
Closed
(WIP) Support for providing of parameters at path level and overriding them…#71portnov wants to merge 1 commit intoHaskell-OpenAPI-Code-Generator:masterfrom
portnov wants to merge 1 commit intoHaskell-OpenAPI-Code-Generator:masterfrom
Conversation
… at operation level.
portnov
changed the title
joel-bach
reviewed
Feb 8, 2022
Member
joel-bach
left a comment
joel-bach
left a comment
There was a problem hiding this comment.
Thank you for your PR, I would definitely like to merge it!
Could you regenerate the golden files (see https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator#development) and maybe also check if the example code has changed?
At least the golden part is needed to get CI passing.
Author
|
Yes, thanks to tests I already see one bug (due to use of Data.Map parameters can be incorrectly reordered). I intend to fix tests this week. |
Member
|
I assume this PR will not be completed, so I'll close it. Feel free to reopen it if you have updates. |
robinp
pushed a commit
to robinp/Haskell-OpenAPI-Client-Code-Generator
that referenced
this pull request
Feb 1, 2026
…or#71 Original PR: Haskell-OpenAPI-Code-Generator#71 Taken over as-is, with minor cleanup and following some renames that happened in the meantime. Golden changes seems benign, but order changes due to Map use. Will clean those up and regen goldens, plus add some test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… at operation level.
This should fix #17.