-
-
Notifications
You must be signed in to change notification settings - Fork 689
Coroutines #12479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Coroutines #12479
+3,587
−391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/context/typecore.ml # src/typing/typeloadCheck.ml # src/typing/typeloadFields.ml # src/typing/typer.ml
_hx_control
closes #34
* try php * and lua
* make coros exception-free * avoid double looping if there's no catch * add more exception tests * add test for nested try-catch * try to get exce[topm value management right * port remaining YieldTryCatch cases * make nested test even crazier * change throw to break to avoid inner exceptions * fix indentation * also test throw from child coro * ignore some tests on lua because there's a codegen issue * lua isn't ready for this * try again * Move recursion tests back to flow control suite * Fix missing import --------- Co-authored-by: Aidan Lee <aidan.lee63@gmail.com>
* make coros exception-free * avoid double looping if there's no catch * add more exception tests * add test for nested try-catch * try to get exce[topm value management right * port remaining YieldTryCatch cases * make nested test even crazier * change throw to break to avoid inner exceptions * fix indentation * also test throw from child coro * ignore some tests on lua because there's a codegen issue * lua isn't ready for this * try again * it works I guess * also add to BlockingContinuation to lose the casts * run JVM tests through hxb roundtrip * be more accurate * deal with LocalFunc type paramters too * use more precise type on suspend * T for all
Get eval test suite running
The reason I prefer this is because it prevents us from accidentally messing up the order.
* optimize * another flag * add missing catch handling, enable reindexing * remove inner recursion from texpr transformer * move functions to where they should be
closes #54
And add basic 3rd party tests (eval only for now)
Move continuations to be the leading argument
# Conflicts: # tests/RunCi.hx
They have moved to hxcoro
Properly track the trailing return expr and inject before that one
Member
Author
|
There are still various issues to sort out but the whole thing is going to be in experimental state for a while anyway, plus I kind of promised that we would get coroutines in 2025, so let's just do it! |
Member
|
Congrats to finally getting this done ;) I have heaps of questions, but I'll just stick to those I can articulate properly:
|
Member
Author
|
Thank you for your interest in our product!
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time has come.