Skip to content

Move MapEntry to js.lib.MapEntry module. #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RealyUniqueName merged 2 commits into from
Sep 5, 2019
Merged

Move MapEntry to js.lib.MapEntry module. #8757

RealyUniqueName merged 2 commits into from
Sep 5, 2019

Conversation

@terurou
Copy link
Member

@terurou terurou commented Sep 4, 2019

Related #8747 and #8754

@terurou
Copy link
Member Author

terurou commented Sep 4, 2019

Should I rename MapEntry to either KeyValue or other?

@RealyUniqueName
Copy link
Member

RealyUniqueName commented Sep 4, 2019

I agree MapEntry doesn't fit now. Maybe ArrayKeyValue is a better name, because KeyValue is usually an object with key and value fields.

@RealyUniqueName
Copy link
Member

RealyUniqueName commented Sep 4, 2019

Though it looks like array-based key-value is used everywhere in JS API. So KeyValue is good too.

@haxiomic
Copy link
Member

haxiomic commented Sep 4, 2019

Thanks @terurou, yeah I vote KeyValue too because it seems like a common thing in ES6

@terurou
Copy link
Member Author

terurou commented Sep 5, 2019 •
edited
Loading

Thanks for your comments!
I rename MapEntry to KeyValue.

@RealyUniqueName RealyUniqueName merged commit be528d9 into HaxeFoundation:development Sep 5, 2019
terurou added a commit to terurou/haxe that referenced this pull request Sep 5, 2019
@terurou
Use KeyValue instead of MapEntry (related HaxeFoundation#8757)
7673f7b
@terurou terurou mentioned this pull request Sep 5, 2019
Merged
@terurou terurou deleted the js-mapentry branch September 5, 2019 13:31
haxiomic pushed a commit that referenced this pull request Sep 5, 2019
@terurou @haxiomic
[js] Fix TypedArray.entries() mistake (#8747)
fa4f902 
* Fix TypedArray.entries()

* Use MayEntry instead of TypedArrayEntry

* Use fully qualified name

* Use KeyValue instead of MapEntry (related #8757)
@terurou terurou mentioned this pull request Sep 14, 2019
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terurou @RealyUniqueName @haxiomic