Skip to content

Marshalling Types #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Simn merged 77 commits into from
Dec 13, 2025
Merged

Marshalling Types #1189

Simn merged 77 commits into from
Dec 13, 2025

Conversation

@Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented Feb 6, 2025 •
edited
Loading

See HaxeFoundation/haxe#11981 for more details

Aidan63 and others added 30 commits December 15, 2024 12:21
@Aidan63
Add marshal header for value type interop
5dfa55a
@Aidan63
finalise boxed objects if the type has a destructor
ec75e42
@Aidan63
works with static cast
b22a024
@Aidan63
add value type tests
4bc2bcc
@Aidan63
move more conversion functions to reference class
44d5a28
@Aidan63
forward declare everything to avoid order issues
0457958
@Aidan63
ValueType construction from boxed pointer
d718eca
@Aidan63
ValueType no longer inherits from struct
ad7f101
@Aidan63
marshal reference interop with existing pointer types
937868a
@Aidan63
Fix trying to dereference a null pointer when creating a boxed object…
5b00db8 
… from a reference
@Aidan63
add compare traits specialisation for reference null check
73d18dc
@Aidan63
consistent null checking and throwing
d4e7dfe
@Aidan63
raise exceptions when value types are assigned null
46e0cd3
@Aidan63
reference equality operations
e7195b4
@Aidan63
remove no return
f92c9a3
remove some un-needed constructors
b49440f
Make constructors use more templates and use reinterpret cast
7f133d3
use tagged dispatch
d86f57c
support pointer types being held in value type helper
9f8ab77
Add new marshal pointer type
cfb6fee
rename marshal types in prep for more pointer stuff
23da6f1
support reinterpreting value type references
de4c7ec
seemingly working pointer marshalling types
8004100
better null checking with pointer references
5572364
add marshalling tests
2ffcf81
Add pointer collection tests
0978d5b
Move enums into header files
d2a9bcf
test abstract around pointers
50301d3
Pointer type changes
b1231af
add pointer reference to pointer casting
20cb53e
Aidan Lee and others added 26 commits November 16, 2025 22:33
String marshalling functions
5f46ac6
@Aidan63
Marshalling tests
5db27ce
@Aidan63
Merge remote-tracking branch 'Aidan63/valuetype-marshal' into valuety…
6639d0c 
…pe-marshal
view based string creation and support char16_t in various hxcpp types
d595c91
@Aidan63
Marshalling string tests
4dc482b
const ref a bit
e15836d
Merge remote-tracking branch 'origin/valuetype-marshal' into valuetyp…
6c64ea8 
…e-marshal
Don't use byte size in copyTo comparison check
4e706d4
@Aidan63
view extension tests
a8b47b5
Split across multiple headers
f3d750a
typed read and write helper functions
5f991de
Add compare function
40e7fa1
cstring to view conversion function, and allow null pointers
4e7bdb9
Add view to pointer conversions
427e81c
View length is now size_t
4e39395
@Aidan63
Add endian specific read and write marshal functions
3d7d9d4
Add OOB checks
513330d
change the public api to use int64_t over size_t
2603e8d
Fix string from view conversions to properly use the view length
14dc9b6
@Aidan63
Add OOB exception tests
a401f07
bound check read and write
43fec7f
make sure view write index is int64_t
c836e3a
Merge branch 'master' into valuetype-marshal
6aac6da
@Aidan63
add tests for exceptions when reading or writing to small views
a18fca8
guard including new marshal headers
d315b3a
fix dodgy conditional
fe7ea65
@Simn Simn merged commit 617aed2 into HaxeFoundation:master Dec 13, 2025
114 of 120 checks passed
@Simn
Copy link
Member

Simn commented Dec 13, 2025

With Haxe being built now, something is actually failing properly:

tests/marshalling/view/TestView.cpp:754:43: error: conversion from 'size_t' (aka 'unsigned long') to '::Dynamic' is ambiguous

@Aidan63
Copy link
Contributor Author

Aidan63 commented Dec 13, 2025

Ah, probably because the size / underlying type of size_t will depend on the architecture and might not have dynamic converions, hence 32bit windows failing and 64bit passing. I'll just change it to int64_t, should be a while until 128bit computers turn up.

@Aidan63 Aidan63 deleted the valuetype-marshal branch December 14, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aidan63 @kevinresol @Simn