Skip to content

Update Stream to v12 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terurou merged 54 commits into from
Oct 9, 2019
Merged

Update Stream to v12 #153

terurou merged 54 commits into from
Oct 9, 2019

Conversation

@terurou
Copy link
Member

@terurou terurou commented Oct 2, 2019

The stream data type has been changed from EitherType<String, Buffer> to Dynamic.
Because the data type cannot be specified for the custom stream.

@takashiski @terurou
update Writable Event Document
1367bcf
@takashiski @terurou
redefie writable.end()
13f31e4
@takashiski @terurou
update writable.setDefaultEncoding()
77e9d14
@takashiski @terurou
update variable on v11
9e76a7b
@takashiski @terurou
add variables on v11 or later
53d431d
@takashiski @terurou
add option functons
4b3437d
@takashiski @terurou
update Writable.new()s options
d9eabb3
@takashiski @terurou
fix typo
d44a407
@takashiski @terurou
comment out redefinitions on http
74cc811
@takashiski @terurou
update Duplex.hx's writable functions
62f2cca
@takashiski @terurou
update
ae9e4c4
@takashiski @terurou
sort ReadableEvent
567bbe0
@takashiski @terurou
update doccomment
a74ece9
@takashiski @terurou
update comment
daf6795
@takashiski @terurou
update comment
20c4d03
@takashiski @terurou
comment out function it return AsyncIteratr
87a3cea
@takashiski @terurou
update duplex
5245a6e
@takashiski @terurou
update Transform
4142dca
@takashiski @terurou
fixed typo
205b92b
@takashiski @terurou
typed transformnewoptions.transform
fa4334a
@takashiski @terurou
remove re-define members on http
0720a9a
@takashiski @terurou
change comment
fd83165
@takashiski @terurou
update passthrough's doc comment
20c6489
@takashiski @terurou
update doccomment
707faf6
@takashiski @terurou
update dccomment
9704f28
@takashiski @terurou
change destroyed access identifier
ca4f30f
@takashiski @terurou
change EitherType to overload
0a4ba5b
@takashiski @terurou
Change EitherType to overload
7b4d3e8
@takashiski @terurou
update
b754191
@takashiski @terurou
update
8fe3479
@terurou terurou requested review from Gama11 and nadako October 2, 2019 14:39
@terurou terurou mentioned this pull request Oct 2, 2019
Open
49 tasks
@Gama11
Copy link
Member

Gama11 commented Oct 3, 2019

What's with all the commented-out fields?

@takashiski
Copy link
Contributor

takashiski commented Oct 4, 2019

These are defined in super class.
If we remove these, we lose time to check field define super class or not defined.
I add comments to show "this field is defined in super class."

@terurou terurou merged commit 462c800 into HaxeFoundation:master Oct 9, 2019
@terurou terurou deleted the stream branch October 9, 2019 00:48
@terurou
Copy link
Member Author

terurou commented Oct 9, 2019

I merged this PR. Thanks @takashiski .
If there are any problems, please report a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gama11 Gama11 Awaiting requested review from Gama11

@nadako nadako Awaiting requested review from nadako

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terurou @Gama11 @takashiski