Skip to content

Toast#116

Merged
100stacks merged 3 commits intomasterfrom
Toast
Oct 21, 2020
Merged

Toast#116
100stacks merged 3 commits intomasterfrom
Toast

Conversation

@nicko-winner
Copy link
Contributor

Add Toast component

@netlify
Copy link

netlify bot commented Oct 16, 2020

Deploy preview for helix-react ready!

Built with commit de927b9

https://deploy-preview-116--helix-react.netlify.app

@nicko-winner nicko-winner added the Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR label Oct 16, 2020
const hxRef = useEventListener({ onDismiss, onSubmit });
return (
<>
<div>
Copy link
Contributor Author

@nicko-winner nicko-winner Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed <> elements don't fix the disappearing react element error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicko-winner, sorry what's this error again? Does the <> cause the error on render?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error happens after helix removes the element from the DOM (by clicking dismiss), and you change pages in storybook. This is the error:
2020-10-16_16-48-23

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks for the explanation. This helps alot. 👍

const hxRef = useEventListener({ onDismiss, onSubmit });
return (
<>
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicko-winner, sorry what's this error again? Does the <> cause the error on render?

@100stacks 100stacks added this to the v1.3.1-alpha milestone Oct 21, 2020
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

const hxRef = useEventListener({ onDismiss, onSubmit });
return (
<>
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks for the explanation. This helps alot. 👍

@100stacks 100stacks merged commit a3db488 into master Oct 21, 2020
@100stacks 100stacks deleted the Toast branch October 21, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants